Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Quickstart Example according to #1477 #1557

Merged
merged 2 commits into from
May 20, 2021

Conversation

aribalam
Copy link
Contributor

@aribalam aribalam commented Apr 30, 2021

Description

This PR updates the quickstart notebook according to #1477.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1557 (29e871c) into master (bf46269) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   67.19%   67.19%           
=======================================
  Files          73       73           
  Lines        6146     6146           
=======================================
  Hits         4130     4130           
  Misses       2016     2016           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf46269...29e871c. Read the comment docs.

@jaladh-singhal
Copy link
Member

@aribalam Just to make sure if the notebook looks fine - can you add [build docs] to an empty commit and link the build documentation?

@aribalam aribalam force-pushed the quickstart_example branch 4 times, most recently from 294208e to a3aa1bf Compare May 17, 2021 15:42
@aribalam aribalam force-pushed the quickstart_example branch from a3aa1bf to 29e871c Compare May 18, 2021 00:55
@aribalam
Copy link
Contributor Author

@jaladh-singhal Preview has been generated. Kindly have a look!
https://aribalam.github.io/tardis/branch/quickstart_example/quickstart/quickstart.html

@andrewfullard andrewfullard merged commit 1d5221a into tardis-sn:master May 20, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* changed example according to new feature

* [build docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants